]> git.mikk.net Git - mtbl-rs/commitdiff
cargo-clippy fixes
authorChris Mikkelson <cmikk@fsi.io>
Sun, 28 Apr 2024 20:57:27 +0000 (15:57 -0500)
committerChris Mikkelson <cmikk@fsi.io>
Sun, 28 Apr 2024 20:57:27 +0000 (15:57 -0500)
Remove redudant Some(foo()?).

Make PartialOrd more canonical.

src/seekable/merge.rs

index 1e182e36c5cd1df0b728fbcd476595c1cef74177..fb9860a8860137b58f287ebfd4b1515165db04d0 100644 (file)
@@ -32,9 +32,7 @@ impl<S: Seekable> PartialEq for MergerEnt<S> {
 // boilerplate.
 impl<S: Seekable> PartialOrd for MergerEnt<S> {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-        let sent = self.cur_item.borrow();
-        let oent = other.cur_item.borrow();
-        oent.0.partial_cmp(&sent.0)
+       Some(self.cmp(other))
     }
 }
 
@@ -68,7 +66,7 @@ where
         active: BinaryHeap::from(
             sources
                 .into_iter()
-                .filter_map(|i| Some(MergerEnt::new(i)?))
+                .filter_map(|i| MergerEnt::new(i))
                 .collect::<Vec<MergerEnt<S>>>(),
         ),
         ended: Vec::new(),